Wireshark-commits: [Wireshark-commits] master 978a30b: nordic_ble: Improved dissector code
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Dec 2016 14:26:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=978a30bd23d37b580afa642ce1b262b3dbd2e899
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

978a30b by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    nordic_ble: Improved dissector code
    
    - Added header fields in a new subtree.
    - Restructured to use fewer functions and to use offset
      counting instead of offset defines.
    - Removed support for legacy version 0.9.7.
    - Removed unused code.
    
    Change-Id: I9eb6c8b3b450ddb95fb0f4bdd9f9717dafa687b0
    Reviewed-on: https://code.wireshark.org/review/19260
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fc8f787   Skip loading the Nordic BLE Sniffer dll on WIN32
    adds  978a30b   nordic_ble: Improved dissector code


Summary of changes:
 epan/dissectors/packet-nordic_ble.c |  711 +++++++++++------------------------
 1 file changed, 210 insertions(+), 501 deletions(-)