Wireshark-commits: [Wireshark-commits] master b1ed528: Remove add_item_text
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Dec 2016 03:57:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1ed5284a3166d0dc169c3f9ae5cf9da14b37fea
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b1ed528 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove add_item_text
    
    It's a manual attempt at what proto_tree_add_bitmask can do anyway.
    
    Change-Id: If551e8afa346a33b8e15dc441aae75ba0752ab46
    Reviewed-on: https://code.wireshark.org/review/19257
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8156e13   packet-lsc.c: Use proto_tree_add_item instead of manually fetching field values.
    adds  b1ed528   Remove add_item_text


Summary of changes:
 epan/dissectors/packet-dnp.c    |   72 +++++++++---------------------
 epan/dissectors/packet-lg8979.c |   93 ++++++++++++++-------------------------
 2 files changed, 53 insertions(+), 112 deletions(-)