Wireshark-commits: [Wireshark-commits] master 7ad655c: rtp_player_dialog.cpp: fix usage of unsuppor
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Dec 2016 23:10:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ad655c9b69f017f880dfd1cd1d0ec4a04479e2b
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7ad655c by Jiri Novak (j.novak@xxxxxxxxxxxx):

    rtp_player_dialog.cpp: fix usage of unsupported method QComboBox::setCurrentText with Qt4.x
    
    QComboBox::setCurrentText() method is available in Qt5.x.
    Older versions code won't compile with it.
    
    Bug: 13235
    Change-Id: Ia2e2713fefe0f2be01a0b77ff1ac39c9162fd0d1
    Reviewed-on: https://code.wireshark.org/review/19219
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  9e9b5ec   Move the declaration of packet_list_select_last_row() to ui/gtk/packet_list.h.
    adds  7ad655c   rtp_player_dialog.cpp: fix usage of unsupported method QComboBox::setCurrentText with Qt4.x


Summary of changes:
 ui/qt/rtp_player_dialog.cpp |    7 +++++++
 1 file changed, 7 insertions(+)