Wireshark-commits: [Wireshark-commits] master-2.0 7ed3dc3: Initialize fd_head->frame in all cases w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Dec 2016 18:40:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ed3dc3f7aa4ff2081cc83fa84f14f2981ac9373
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

7ed3dc3 by Guy Harris (guy@xxxxxxxxxxxx):

    Initialize fd_head->frame in all cases where we allocate fd_head.
    
    Also, sort the initializations of structure members by the order in the
    structure, to make it easier to check that we've initialized them all.
    
    Bug: 13231
    Change-Id: Id2819940d916a5fd5a3f1bf2fc20bd3ee34a75f4
    Reviewed-on: https://code.wireshark.org/review/19195
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 2dfa603333416aec69719fb074388886f0fc96b2)
    Reviewed-on: https://code.wireshark.org/review/19197
    

Actions performed:

    from  1965249   [ICMP] use abs() in detecting timestamp heuristics
    adds  7ed3dc3   Initialize fd_head->frame in all cases where we allocate fd_head.


Summary of changes:
 epan/reassemble.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)