Wireshark-commits: [Wireshark-commits] master 00223bc: Qt: Avoid infinite recursion in ExtcapArgume
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Dec 2016 14:43:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=00223bc5b9f3c34a365759fceb49684b4496051a
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

00223bc by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Avoid infinite recursion in ExtcapArgument::loadValues
    
    If configuring a extcap "value" sentence with {value=} then loadValues()
    must not run in a infinite recursion trying to find it's children.
    
    Change-Id: Ic2577b31d9312e8f6a099c4fe7c0672e801dbc89
    Reviewed-on: https://code.wireshark.org/review/19192
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  6a4226e   ssh: organize header field IDs
    adds  00223bc   Qt: Avoid infinite recursion in ExtcapArgument::loadValues


Summary of changes:
 ui/qt/extcap_argument.cpp |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)