Wireshark-commits: [Wireshark-commits] master f60ec25: [ICMP] use abs() in detecting timestamp heur
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 9 Dec 2016 18:26:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f60ec2581ae825f89e669ca4b4f14917a2aab561
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f60ec25 by Michael Mann (mmann78@xxxxxxxxxxxx):

    [ICMP] use abs() in detecting timestamp heuristics
    
    The code was making the assumption that the ICMP data time will always
    be greater than or equal to the frame time, but not earlier, but that
    is not always the case and the heuristics can fail.
    
    Bug: 13161
    Change-Id: I4bc7bd8d22d717d3b1f08afdd651f8a70cb7aef2
    Reviewed-on: https://code.wireshark.org/review/19157
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  2984193   [RTP] Don't call p_get_proto_data() twice
    adds  f60ec25   [ICMP] use abs() in detecting timestamp heuristics


Summary of changes:
 epan/dissectors/packet-icmp.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)