Wireshark-commits: [Wireshark-commits] master-2.2 43b76c5: packet-rpcrdma: Remove if (tree) prevent
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2016 22:48:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=43b76c53de10bde016e56f7cf8f7fd0ca325640e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

43b76c5 by Chuck Lever (chuck.lever@xxxxxxxxxx):

    packet-rpcrdma: Remove if (tree) preventing dissectors being called.
    
    When tshark displays each frame in default mode (without -V):
    
    - NFS on TCP is dissected and displayed
    - NFS on RPC/RDMA is displayed as only an RPC/RDMA frame
    
    NFS on RPC/RDMA should be dissected and displayed just like NFS on
    TCP. Make passing along the RPC payload to the RPC dissector
    unconditional.
    
    Bug: 13198
    Change-Id: Ia86f3abcfcbc65a860d4ff7bac19a5f3af44a0b0
    Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/19027
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 026b2f99293d1eb75f29178fc1ffd86dbe22fe7d)
    Reviewed-on: https://code.wireshark.org/review/19104
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3508aee   SMB: Limit Export object files to 32 bits.
    adds  43b76c5   packet-rpcrdma: Remove if (tree) preventing dissectors being called.


Summary of changes:
 epan/dissectors/packet-rpcrdma.c |  113 +++++++++++++++++++-------------------
 1 file changed, 55 insertions(+), 58 deletions(-)