Wireshark-commits: [Wireshark-commits] master e0a4f0c: SMB: Limit Export object files to 32 bits.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Dec 2016 06:30:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0a4f0c79b68830547dab1baad7641a09b4d93f5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e0a4f0c by Michael Mann (mmann78@xxxxxxxxxxxx):

    SMB: Limit Export object files to 32 bits.
    
    Most of the file offset fields are 32-bit, but the algorithms use gsize
    variables, which can vary between 32 and 64 bit builds.  The 64-bit
    builds are the ones with the problem with "garbage" data comes from
    (effectively) invalid 32-bit offsets.
    
    Bug: 11133
    Change-Id: I20b8cafb75fc021594159ab092c18c24f3e257e3
    Reviewed-on: https://code.wireshark.org/review/19073
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  26def3e   Honor protocols.display_hidden_proto_items preferences when outputting fields in TShark
    adds  e0a4f0c   SMB: Limit Export object files to 32 bits.


Summary of changes:
 epan/dissectors/packet-smb.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)