Wireshark-commits: [Wireshark-commits] master 40ebfb9: ssh: fix the heuristic for MAC size determin
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=40ebfb9a6f180b5b6deb0ed727e38c98e848b6cb
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
40ebfb9 by Роман Донченко (dpb@xxxxxxxxxxxxxx):
ssh: fix the heuristic for MAC size determination
size_str points to a dash, so the result of calling ws_strtoi32 on it is
a negative number, which becomes a huge positive number, because size is
a guint32.
Parse the number after the dash instead, and use ws_strtou32.
Also, check that size is divisible by 8, since otherwise it's unlikely
to be a bit length.
Change-Id: I531f67d45e9e914574d36a9ffceed9239fd46d64
Reviewed-on: https://code.wireshark.org/review/19006
Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Petri-Dish: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from dd98856 Have separate merge APIs for regular file/temporary file/standard output.
adds 40ebfb9 ssh: fix the heuristic for MAC size determination
Summary of changes:
epan/dissectors/packet-ssh.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)