Wireshark-commits: [Wireshark-commits] master 3309c08: When opening the standard output for writing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 3 Dec 2016 22:18:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3309c08cd03a16438e6189bf4547ca172f90330a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3309c08 by Guy Harris (guy@xxxxxxxxxxxx):

    When opening the standard output for writing, dup it.
    
    That way, we can close the resulting wtap_dumper the same way we close
    any other wtap_dumper, including closing the FD, rather than trying to
    do everything *except* closing the FD (which is tricky for a FILE *).
    
    Change-Id: I8cb66e32784d73e598b2e8720a12f9bdab1c6205
    Reviewed-on: https://code.wireshark.org/review/19054
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a0d03ce   ssh: dissect the host key when the connection uses DH group exchange
    adds  3309c08   When opening the standard output for writing, dup it.


Summary of changes:
 wiretap/file_access.c   |   68 ++++++++++++++++++-----------------------------
 wiretap/file_wrappers.c |   16 +++--------
 wiretap/file_wrappers.h |    2 +-
 wiretap/wtap-int.h      |    1 -
 4 files changed, 31 insertions(+), 56 deletions(-)