Wireshark-commits: [Wireshark-commits] master db7c628: Temporarily break up complicated expression
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 3 Dec 2016 04:09:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db7c6286169015a727024e86eb270722127125bb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

db7c628 by Guy Harris (guy@xxxxxxxxxxxx):

    Temporarily break up complicated expression into a bunch of separate ifs.
    
    Maybe this way we can identify which *particular* test is, according to
    Valgrind, looking at uninitialized data; there's nothing obvious that
    shows up from inspecting the code, and neither of our static analyzers
    seem to have found anything.
    
    Change-Id: I80f6bb8e6fa92decfe195c01766330b97e980821
    Reviewed-on: https://code.wireshark.org/review/19049
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2462f9e   packet-rpcrdma: Fix protocol frame pre-detection
    adds  db7c628   Temporarily break up complicated expression into a bunch of separate ifs.


Summary of changes:
 epan/dissectors/packet-cops.c |   63 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)