Wireshark-commits: [Wireshark-commits] master 42f0695: Fix two warnings when compiling with rpcap s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 30 Oct 2016 08:44:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=42f0695f4d84093a1617ee1f35ee724aa4d98166
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

42f0695 by Joerg Mayer (jmayer@xxxxxxxxx):

    Fix two warnings when compiling with rpcap support on macOS.
    
    One is an unused variable warning turning error, the other is
    
    [ 71%] Building C object ui/CMakeFiles/ui.dir/recent.c.o
    /Users/jmayer/worktmp/wireshark/git/ui/recent.c:494:23: error: implicit conversion loses integer precision:
          'glong' (aka 'long') to 'gint' (aka 'int') [-Werror,-Wshorten-64-to-32]
          rh->auth_type = auth_type;
                        ~ ^~~~~~~~~
    1 error generated.
    
    Please review.
    
    Change-Id: If838f8fa1e8a76dc8c6cc78db495befdd527da92
    Reviewed-on: https://code.wireshark.org/review/18544
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  b8a766a   DHCPv6: Remove check for Relay Data option about Bulk Leasequery reply
    adds  42f0695   Fix two warnings when compiling with rpcap support on macOS.


Summary of changes:
 ui/qt/remote_capture_dialog.cpp |    2 --
 ui/recent.c                     |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)