Wireshark-commits: [Wireshark-commits] master 183856f: ISAKMP: Rename identifiers for readability
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 28 Oct 2016 22:00:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=183856f7240288f67898b2a2110b7f51a0c0f2b6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

183856f by Mirko Parthey (mirko.parthey@xxxxxx):

    ISAKMP: Rename identifiers for readability
    
    Rename attribute dissecting functions and their local variables to
    improve code readability, and adjust white space.
    
    old                               new
    ------------------------------------------------------------------
    dissect_rohc_supported            dissect_rohc_attribute
    dissect_transform_ike2_attribute  dissect_ike2_transform_attribute
    option                            attribute
    optlen                            value_len
    
    rohc                              attr_type
    transform_attr_type               attr_type
    cfg_attr_type                     attr_type
    
    rohc_tree                         tree
    transform_attr_type_tree          tree
    cfg_attr_type_tree                tree
    
    sub_rohc_tree                     attr_tree
    sub_transform_attr_type_tree      attr_tree
    sub_cfg_attr_type_tree            attr_tree
    
    rohc_item                         attr_item
    transform_attr_type_item          attr_item
    cfg_attr_type_item                attr_item
    ------------------------------------------------------------------
    
    Change-Id: I135e5deb802edc575e7fddd1bb397272aac0888c
    Reviewed-on: https://code.wireshark.org/review/18553
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d36a0c9   hpfeeds: don't pass channel name to heuristic dissector.
    adds  183856f   ISAKMP: Rename identifiers for readability


Summary of changes:
 epan/dissectors/packet-isakmp.c |  474 +++++++++++++++++++--------------------
 1 file changed, 237 insertions(+), 237 deletions(-)