Wireshark-commits: [Wireshark-commits] master-2.2 f44fd03: alljoyn: fix signature length adjustment
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 23 Oct 2016 09:50:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f44fd03955e1023165cb661f9fe05d53ba7ee540
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

f44fd03 by Peter Wu (peter@xxxxxxxxxxxxx):

    alljoyn: fix signature length adjustments
    
    Ensure that the signature pointer and length always matches, otherwise a
    buffer overrun (read) is possible.
    
    Tested with the original captures from bug 12953, the PDML output is
    still the same while the fuzzed capture does not crash anymore.
    
    Bug: 12953
    Change-Id: I8843a5daf98a79fb19906e824326cdf619164484
    Reviewed-on: https://code.wireshark.org/review/18347
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    (cherry picked from commit 7dfaec969e67e3aa14b9763d804802ef614c9ddd)
    Reviewed-on: https://code.wireshark.org/review/18408
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a8cad85   AMPQ: Fix malformed packed in session.expected and session.confirmed.
    adds  f44fd03   alljoyn: fix signature length adjustments


Summary of changes:
 epan/dissectors/packet-alljoyn.c |   31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)