Wireshark-commits: [Wireshark-commits] master 5f68435: Fix the #defines for the presence of structu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Oct 2016 09:53:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f68435a079dc7ce633e1da22f363e4e715d66f6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5f68435 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix the #defines for the presence of structure names.
    
    AC_CHECK_MEMBER() and AC_CHECK_MEMBERS() use a standard name for the
    {structurename} being the name of the structure type, complete with
    "struct" if a typedef wasn't used, and with all letters mapped to upper
    case, and with {membername} being the name of the structure member, with
    all letters mapped to upper case.
    
    check_struct_has_member() lets you choose the name; choose the same name
    that the autoconf macros use, and fix the code to check for them.
    
    Change-Id: Ifb3cf65e7e94907ad0a2f8aacca0c21a531f0c5b
    Reviewed-on: https://code.wireshark.org/review/18382
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d32fee2   Qt/Bluetooth: Add Display Filter Edit field to HCI Summary dialogue
    adds  5f68435   Fix the #defines for the presence of structure names.


Summary of changes:
 ConfigureChecks.cmake             |    8 ++++----
 caputils/capture-pcap-util-unix.c |    2 +-
 cmakeconfig.h.in                  |    4 ++--
 ui/gtk/file_dlg.c                 |   10 +++++-----
 4 files changed, 12 insertions(+), 12 deletions(-)