Wireshark-commits: [Wireshark-commits] master 991e074: Qt: fix weird tree expander that results in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Oct 2016 14:14:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=991e0747a3b0bbeddb27dc29e53fa6dbb5c68e4b
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

991e074 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix weird tree expander that results in a crash
    
    According to the Qt documentation, rowCount and columnCount must return
    0 when a valid parent index is passed to a table model. Otherwise deep
    recursion would occur resulting in a stack overflow in Qt4.
    
    Change-Id: I60bb15384470861013591e149c0f285ea1bdf9a7
    Fixes: v2.3.0rc0-1002-g1cd2255 ("Qt: convert UatDialog to model/view pattern, improve UX")
    Reviewed-on: https://code.wireshark.org/review/18354
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  67bfdf2   capchild: Fix loading of extcap with no winpcap.dll
    adds  991e074   Qt: fix weird tree expander that results in a crash


Summary of changes:
 ui/qt/uat_model.cpp |   15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)