Wireshark-commits: [Wireshark-commits] master 93b2b2c: Eliminate a global variable.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Oct 2016 23:03:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=93b2b2c06d2c8b6bbc3f204633c654383b0ce8ac
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

93b2b2c by Guy Harris (guy@xxxxxxxxxxxx):

    Eliminate a global variable.
    
    Have the packet length be a local variable, and pass it to routines.
    Yes, that means we fetch it twice - no great loss.
    
    Change-Id: Id9f95b3d8a19bf235d6b19993165e0f73a2e5732
    Reviewed-on: https://code.wireshark.org/review/18211
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7417436   Fix bin2hex().
    adds  93b2b2c   Eliminate a global variable.


Summary of changes:
 epan/dissectors/packet-iso8583.c |   25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)