Wireshark-commits: [Wireshark-commits] master 0674a92: RakNet: fix heuristic dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Oct 2016 17:28:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0674a92cffa2a68d866aa453673a9fbbd723fed6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0674a92 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    RakNet: fix heuristic dissector
    
    RAKNET_OFFLINE_MESSAGE_DATA_ID starts with 0x0, which means NULL
    character. this give a string of length 0 and RakNet heuristic was
    wrongly catching all UDP packets.
    Let's do a memcmp instead of a strncmp.
    
    Change-Id: I38e98838b114037bf37a218003bade88261a2dd8
    Reviewed-on: https://code.wireshark.org/review/18167
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6ae3ba0   M3AP: register dissector by name
    adds  0674a92   RakNet: fix heuristic dissector


Summary of changes:
 epan/dissectors/packet-raknet.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)