Wireshark-commits: [Wireshark-commits] master bff2f93: isakmp: Add dissection of Responder Lifetime
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 5 Oct 2016 04:17:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bff2f93c7d1f4bdba3c141441c57eff8697dbb94
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bff2f93 by Mirko Parthey (mirko.parthey@xxxxxx):

    isakmp: Add dissection of Responder Lifetime notification
    
    Derive the dissection functions from
    dissect_ike_attribute() and dissect_ipsec_attribute():
    * Add dedicated header fields.
    * Remove attribute types not applicable in Responder Lifetime context.
    
    Clean up the field name "isakmp.ipsec.attr.type".
    
    Bug: 12963
    Change-Id: I486380836d915255812098be2190bcc77ec13c00
    Reviewed-on: https://code.wireshark.org/review/17970
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  cb95951   tvbuff_zlib: Check if the given offset and compressed length are indeed valid before trying to allocate memory
    adds  bff2f93   isakmp: Add dissection of Responder Lifetime notification


Summary of changes:
 epan/dissectors/packet-isakmp.c |  190 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 188 insertions(+), 2 deletions(-)