Wireshark-commits: [Wireshark-commits] master 76cf240: SMPP: Make smpp.message a FT_BYTES field.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 4 Oct 2016 16:53:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=76cf240a0bbe142829083189f943dcc85c7f1223
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

76cf240 by Michael Mann (mmann78@xxxxxxxxxxxx):

    SMPP: Make smpp.message a FT_BYTES field.
    
    As an FT_NONE field, you can't filter/use the message it contains.
    
    Bug: 12960
    Change-Id: Icaa9a260195711f1bd90f5ed14797c0d0c46de9c
    Reviewed-on: https://code.wireshark.org/review/18063
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ca2ac99   h248_annex_c: use ws_strtoi function.
    adds  76cf240   SMPP: Make smpp.message a FT_BYTES field.


Summary of changes:
 epan/dissectors/packet-smpp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)