Wireshark-commits: [Wireshark-commits] master 650c0f9: p1: Check for valid tvb before tvb_reported_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 3 Oct 2016 19:42:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=650c0f93be4765c8a2dc2db035fe1d0542a047c3
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

650c0f9 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    p1: Check for valid tvb before tvb_reported_length
    
    Move the modification of the content item (which adds the length)
    inside the check for a valid tvb to avoid calling tvb_reported_length()
    with a NULL parameter.
    
    Bug: 12976
    Change-Id: I54368584b7c00f7a2937eaec772533ae73d98f80
    Reviewed-on: https://code.wireshark.org/review/18050
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  1320ea4   Be more forgiving about invalid Coloring Rules.
    adds  650c0f9   p1: Check for valid tvb before tvb_reported_length


Summary of changes:
 epan/dissectors/asn1/p1/p1.cnf |    2 +-
 epan/dissectors/packet-p1.c    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)