Wireshark-commits: [Wireshark-commits] master 534787e: cmake: make WERROR_COMMON_FLAGS a normal str
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 30 Sep 2016 20:08:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=534787e402d6aa8b349638f911a2a65b013c6594 Submitter: Dario Lombardo (lomato@xxxxxxxxx) Changed: branch: master Repository: wireshark Commits: 534787e by Peter Wu (peter@xxxxxxxxxxxxx): cmake: make WERROR_COMMON_FLAGS a normal string Instead of checking for the boolean "FALSE", just set an empty string. This avoids the need to check for WERROR_COMMON_FLAGS before using it. The transformation is the same for all files, remove "if (WERROR_COMMON_FLAGS)" and "endif()", reindent and add quotes (since we have a string here and not a list). Modelines have been added where missing. Change-Id: I0ab05ae507c51fa77336d49a99a226399cc81b92 Reviewed-on: https://code.wireshark.org/review/17997 Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: João Valverde <j@xxxxxx> Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx> Tested-by: Dario Lombardo <lomato@xxxxxxxxx> Actions performed: from 53c9197 kismet: use cast in ws_strtou. adds 534787e cmake: make WERROR_COMMON_FLAGS a normal string Summary of changes: CMakeLists.txt | 17 +++++++---------- capchild/CMakeLists.txt | 25 ++++++++++++++++++------- caputils/CMakeLists.txt | 25 ++++++++++++++++++------- echld/CMakeLists.txt | 25 ++++++++++++++++++------- epan/CMakeLists.txt | 12 +++++------- epan/crypt/CMakeLists.txt | 12 +++++------- epan/dfilter/CMakeLists.txt | 12 +++++------- epan/dissectors/CMakeLists.txt | 12 +++++------- epan/dissectors/dcerpc/CMakeLists.txt | 12 +++++------- epan/ftypes/CMakeLists.txt | 12 +++++------- epan/nghttp2/CMakeLists.txt | 12 +++++------- epan/wmem/CMakeLists.txt | 12 +++++------- epan/wslua/CMakeLists.txt | 12 +++++------- plugins/docsis/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/ethercat/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/gryphon/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/irda/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/m2m/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/mate/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/opcua/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/profinet/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/stats_tree/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/tpg/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/unistim/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/wimax/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/wimaxasncp/CMakeLists.txt | 25 ++++++++++++++++++------- plugins/wimaxmacphy/CMakeLists.txt | 25 ++++++++++++++++++------- randpkt_core/CMakeLists.txt | 25 ++++++++++++++++++------- tools/lemon/CMakeLists.txt | 25 ++++++++++++++++++------- ui/CMakeLists.txt | 12 +++++------- ui/gtk/CMakeLists.txt | 12 +++++------- ui/qt/CMakeLists.txt | 12 +++++------- wiretap/CMakeLists.txt | 25 ++++++++++++++++++------- writecap/CMakeLists.txt | 25 ++++++++++++++++++------- wsutil/CMakeLists.txt | 31 ++++++++----------------------- 35 files changed, 453 insertions(+), 264 deletions(-)
- Prev by Date: [Wireshark-commits] master 53c9197: kismet: use cast in ws_strtou.
- Next by Date: [Wireshark-commits] master 11c1024: wsutil: split libjsmn.
- Previous by thread: [Wireshark-commits] master 53c9197: kismet: use cast in ws_strtou.
- Next by thread: [Wireshark-commits] master 11c1024: wsutil: split libjsmn.
- Index(es):