Wireshark-commits: [Wireshark-commits] master 1f633cf: Qt: Add html_escape to qt_ui_utils.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Sep 2016 19:41:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f633cfc840de148e928d121a613237ea5dafb0a
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1f633cf by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add html_escape to qt_ui_utils.
    
    Add an html_escape convenience function, which escapes HTML
    metacharacters using Qt::escape on Qt4 and QString::toHtmlEscaped on
    Qt5. Use it where we were previously using #if QT_VERSION and calling
    the API-specific functions.
    
    Change-Id: Ifda3e9634a37fc00bdb46e08d5711f934692fef5
    Reviewed-on: https://code.wireshark.org/review/17984
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  5f69295   macosx-setup: Upgrade c-ares to 1.12.0.
    adds  1f633cf   Qt: Add html_escape to qt_ui_utils.


Summary of changes:
 ui/qt/capture_file_properties_dialog.cpp |   13 ++-----------
 ui/qt/module_preferences_scroll_area.cpp |   13 ++-----------
 ui/qt/preference_editor_frame.cpp        |   12 +-----------
 ui/qt/qt_ui_utils.cpp                    |   14 ++++++++++++++
 ui/qt/qt_ui_utils.h                      |    9 +++++++++
 ui/qt/sequence_dialog.cpp                |   11 ++---------
 ui/qt/tap_parameter_dialog.cpp           |   26 ++++----------------------
 7 files changed, 34 insertions(+), 64 deletions(-)