Wireshark-commits: [Wireshark-commits] master 814477c: PROFINET: Fix pointer variable 'fp' previous
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Sep 2016 00:50:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=814477c32f9ac7838cf7364fcc83f36378ea2159
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

814477c by Birol Capa (birol.capa@xxxxxxxxxxx):

    PROFINET: Fix pointer variable 'fp' previously deallocated warning
    
    'fp' pointer variable was freed or deleted in an earlier statement.
    
    To make code more readable and to avoid possible future mistakes
    make sure that developer sees this situation.
    
    Change-Id: Ib5b9c4c32000adf05a30e094ebc98fe4bc4cfa52
    Reviewed-on: https://code.wireshark.org/review/17961
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  48a6683   Use wtap_read_bytes() to skip over bytes when reading a record.
    adds  814477c   PROFINET: Fix pointer variable 'fp' previously deallocated warning


Summary of changes:
 plugins/profinet/packet-dcerpc-pn-io.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)