Wireshark-commits: [Wireshark-commits] master 152e245: proto_tree_add_item_ret_(u)int/proto_tree_ad
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Sep 2016 06:07:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=152e245804397bfcd0fc3e4cfac22e1d49b0b169
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

152e245 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    proto_tree_add_item_ret_(u)int/proto_tree_add_bitmask_with_flags_ret_uint64: return real value
    
    Apply mask and bit shift on the returned value.
    
    Change-Id: I00aebc854756f01a25199a259d6d5252abea4349
    Reviewed-on: https://code.wireshark.org/review/17958
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f8b32e5   checkAPIs.pl: Avoid false positive in header
    adds  152e245   proto_tree_add_item_ret_(u)int/proto_tree_add_bitmask_with_flags_ret_uint64: return real value


Summary of changes:
 epan/dissectors/asn1/rrc/rrc.cnf       |    2 +-
 epan/dissectors/packet-enip.c          |    2 +-
 epan/dissectors/packet-gsm_abis_pgsl.c |    2 --
 epan/dissectors/packet-gsm_abis_tfp.c  |   11 ++++-------
 epan/dissectors/packet-gtpv2.c         |    2 +-
 epan/dissectors/packet-ieee1722.c      |    1 -
 epan/dissectors/packet-mac-lte.c       |   13 +++++++------
 epan/dissectors/packet-nas_eps.c       |    6 +++---
 epan/dissectors/packet-pdcp-lte.c      |   13 ++-----------
 epan/dissectors/packet-rrc.c           |    2 +-
 epan/dissectors/packet-rsl.c           |    1 -
 epan/proto.c                           |   28 ++++++++++++++++++++++++++--
 epan/proto.h                           |    6 +++---
 13 files changed, 49 insertions(+), 40 deletions(-)