Wireshark-commits: [Wireshark-commits] master b725d6c: Add an initial "shellcheck" target.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Sep 2016 23:17:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b725d6c9acc403dba30c72d20cf7103e4f490334
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b725d6c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add an initial "shellcheck" target.
    
    Look for shellcheck in Autotools and CMake, and if found add a target
    that checks some of our shell scripts.
    
    Add a "source=" directive to targets that include test-common.sh so
    that shellcheck will correctly process the scripts. Note that this
    requires shellcheck 0.4.0 or later.
    
    To do: Fix the issues that shellcheck found and check more scripts.
    
    Change-Id: I441f9f59d8a3f8eec6718119c2370f2560b98f3c
    Reviewed-on: https://code.wireshark.org/review/17943
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  06352a2   Reorganize the source lists.
    adds  b725d6c   Add an initial "shellcheck" target.


Summary of changes:
 CMakeLists.txt         |   19 +++++++++++++++++++
 Makefile.am            |   16 ++++++++++++++++
 configure.ac           |    4 ++++
 tools/fuzz-test.sh     |    1 +
 tools/randpkt-test.sh  |    1 +
 tools/test-captures.sh |    1 +
 6 files changed, 42 insertions(+)