Wireshark-commits: [Wireshark-commits] master 0ee1445: Improve HART dissector
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Sep 2016 07:33:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ee1445ada61c4b21b7abb70ee50050a34932ac6
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0ee1445 by rosemountSkp (rosemountSkp@xxxxxxxxxxxxxxxxxx):

    Improve HART dissector
    
    Fixed short command 0 short address,
    command 0 that has less bytes,
    command 9 byte count,
    command 48 parse first 6 bytes instead of 5 and
    the command may has less bytes, pass correct byte count into the
    dissect_parse_hart_cmds() function.
    
    Added support HART published and NAK message types and more HART commands.
    
    Bug: 12817
    Change-Id: I4a9e7f9b342346ff4ecdcd06a73238c1a08d00fc
    Reviewed-on: https://code.wireshark.org/review/17325
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  870822b   eap: add imsi to wlan identity dissection.
    adds  0ee1445   Improve HART dissector


Summary of changes:
 epan/dissectors/packet-hartip.c |  743 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 711 insertions(+), 32 deletions(-)