Wireshark-commits: [Wireshark-commits] master 8b04755: ssl-utils: fix decryption of NULL ciphers
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Sep 2016 12:35:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b047554ee93fbbf7731da371df0779acc9fc87a
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8b04755 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: fix decryption of NULL ciphers
    
    A dissector bug was reported:
    
        epan/dissectors/packet-ssl-utils.c:1615: failed assertion "data"
    
    and fair enough, the MAC Key is indeed NULL because of our special
    handling for NULL ciphers. Just ignore the MAC key then.
    
    Change-Id: I12d2be5e84520badb44a99fc965c48c3afa89346
    Fixes: v2.3.0rc0-697-gb1d36fe ("ssl-utils: remove block and key sizes from cipher suites table")
    Reviewed-on: https://code.wireshark.org/review/17903
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  ca232b1   Udpdump: Fix g_debug() for ssize_t buflen
    adds  8b04755   ssl-utils: fix decryption of NULL ciphers


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)