Wireshark-commits: [Wireshark-commits] master 7477e1c: Fix Profinet RPCInterfaceUUID decoding
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Sep 2016 15:42:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7477e1c3b90cedfe0d154f5b4c8eb9e5d7e26b59
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7477e1c by Birol Capa (birol.capa@xxxxxxxxxxx):

    Fix Profinet RPCInterfaceUUID decoding
    
    The translation of all RPCInterfaceUUID for PNIO evaluates to "PNIO".
    However, UUID allows distinction of
     - UUID_IO_DeviceInterface (IOD-IF)
     - UUID_IO_ControllerInterface (IOC-IF)
     - UUID_IO_SupervisorInterface (IOS-IF)
     - UUID_IO_ParameterServerInterface (PServ-IF)
    
    Bug: 12938
    Change-Id: I97c27808f61abd96728421488bb0ee5fdbace566
    Reviewed-on: https://code.wireshark.org/review/17865
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  f4a521e   [proto.c] As we know the size of the hf array use g_ptr_array_sized_new() to allocate the arry to hold them. This should be more efficient.
    adds  7477e1c   Fix Profinet RPCInterfaceUUID decoding


Summary of changes:
 plugins/profinet/packet-dcerpc-pn-io.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)