Wireshark-commits: [Wireshark-commits] master f87d1ab: WiX: Fix condition logic.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 22 Sep 2016 00:50:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f87d1ab69996753e4c40854bac9aecbfd7cc0c98
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f87d1ab by Gerald Combs (gerald@xxxxxxxxxxxxx):

    WiX: Fix condition logic.
    
    The condition expressions in g630b646 were incorrect. Fix them. This
    also lets us make the error messages more verbose, so do so. Add a hint
    about debugging.
    
    Change-Id: I74d4b9cfb1bc9afb23be4d61ac190f90e7048745
    Reviewed-on: https://code.wireshark.org/review/17849
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  f513dd3   ethertype: add missing value_string row for MACSEC
    adds  f87d1ab   WiX: Fix condition logic.


Summary of changes:
 packaging/wix/Prerequisites.wxi |   40 ++++++++++++++++-----------------------
 1 file changed, 16 insertions(+), 24 deletions(-)