Wireshark-commits: [Wireshark-commits] master 811bb33: netlink: make dissect_netlink_attributes() e
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 20 Sep 2016 09:13:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=811bb3302bf503523f51c219226426feb63b7a18
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

811bb33 by Hauke Mehrtens (hauke.mehrtens@xxxxxxxxx):

    netlink: make dissect_netlink_attributes() endianness aware
    
    Always give the netlink data struct to dissect_netlink_attributes() so
    we can extract which endianness we should use. This fixes the netlink
    dissector on big endian.
    
    Change-Id: Ia485a29035c947908c29a9e30d0aba8d4fc94093
    Signed-off-by: Hauke Mehrtens <hauke.mehrtens@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/17636
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  b1bbfaa   netlink: try to detect endianness
    adds  811bb33   netlink: make dissect_netlink_attributes() endianness aware


Summary of changes:
 epan/dissectors/packet-netlink-netfilter.c |   16 ++++++++--------
 epan/dissectors/packet-netlink-route.c     |    2 +-
 epan/dissectors/packet-netlink-sock_diag.c |    8 ++++----
 epan/dissectors/packet-netlink.c           |   21 +++++++++++++--------
 epan/dissectors/packet-netlink.h           |    2 +-
 5 files changed, 27 insertions(+), 22 deletions(-)