Wireshark-commits: [Wireshark-commits] lts-1.12.1 8e34115: FP: ensure that mac and rlc structures a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Sep 2016 15:39:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8e3411505ad2a420d7ef96eb52f2b1c02b0c4380
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

8e34115 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    FP: ensure that mac and rlc structures are always allocated
    
    Rather han checking everywhere that the RLC and MAC info are present in pinfo,
    allocate a temporary structure that will be dropped once packet dissection is
    over.
    
    Conflicts:
    	epan/dissectors/packet-umts_fp.c
    
    Bug: 12751
    Change-Id: I890430dd0c0b56d641777c15eedbf07fef082904
    Reviewed-on: https://code.wireshark.org/review/17094
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 315bba7c645b75af24215c6303d187b188610bba)
    Reviewed-on: https://code.wireshark.org/review/17102
    Reviewed-on: https://code.wireshark.org/review/17801
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  f6cd7ea   DCT2000: fix a buffer overflow in case of malformed packet
    adds  8e34115   FP: ensure that mac and rlc structures are always allocated


Summary of changes:
 epan/dissectors/packet-umts_fp.c |   29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)