Wireshark-commits: [Wireshark-commits] lts-1.12.1 8b20fac: Don't snprintf() into a string with one
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Sep 2016 15:37:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b20fac0cdcbeb0266caf5307600e1e1f4912b99
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

8b20fac by Guy Harris (guy@xxxxxxxxxxxx):

    Don't snprintf() into a string with one of the arguments being the same string.
    
    That doesn't work - you could be writing into the string from which
    you're reading.
    
    Conflicts:
    	asn1/h225/h225.cnf
    	epan/dissectors/packet-h225.c
    
    Bug: 12700
    
    Change-Id: I2fc6416e0613791dcd37ef70dbf00aae159008de
    Reviewed-on: https://code.wireshark.org/review/16852
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/17800
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  301713b   proto.c: do not perform bound checks in proto_tree_add_text(_valist)_internal if tvb is NULL
    adds  8b20fac   Don't snprintf() into a string with one of the arguments being the same string.


Summary of changes:
 asn1/h225/h225.cnf            |   58 ++++++++------
 epan/dissectors/packet-h225.c |  168 ++++++++++++++++++++++-------------------
 2 files changed, 127 insertions(+), 99 deletions(-)