Wireshark-commits: [Wireshark-commits] master 22257e8: p_XXX_proto_data: only allow the use of pinf
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 Sep 2016 15:46:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22257e8cf5a497cd16dd7336a9b8dd224285ee39
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

22257e8 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    p_XXX_proto_data: only allow the use of pinfo and file scopes
    
    Those are the only ones meaningful. Let's convert the buggy dissectors
    and add an assert to avoid the misuse of the pool parameter in the future
    
    Change-Id: I65f470b757f163f11a25cd352ffe168d1f8a86d3
    Reviewed-on: https://code.wireshark.org/review/17748
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  2832f4e   NSIS: add UDPdump to installer
    adds  22257e8   p_XXX_proto_data: only allow the use of pinfo and file scopes


Summary of changes:
 epan/dissectors/asn1/h225/h225.cnf               |   84 +++++++++++-----------
 epan/dissectors/asn1/h225/packet-h225-template.c |    4 +-
 epan/dissectors/packet-amqp.c                    |   10 +--
 epan/dissectors/packet-dof.c                     |   18 ++---
 epan/dissectors/packet-h225.c                    |   66 ++++++++---------
 epan/proto_data.c                                |   16 +++--
 epan/proto_data.h                                |    1 +
 7 files changed, 104 insertions(+), 95 deletions(-)