Wireshark-commits: [Wireshark-commits] master 2c33f74: extcap: fix heap-use-after free after saving
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 Sep 2016 10:44:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c33f74bc68c0356eb44a11918d690ac8f26ab63
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2c33f74 by Peter Wu (peter@xxxxxxxxxxxxx):

    extcap: fix heap-use-after free after saving prefs
    
    All strings passed to prefs must be valid for the lifetime of the
    program (before prefs_cleanup is called). Use wmem for this purpose.
    Fixes v2.3.0rc0-660-g26bf66f
    
    Change-Id: I94f3bbb8ac6e18ae59d6462525f6bbc46fdb0f1f
    Reviewed-on: https://code.wireshark.org/review/17737
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  05ae6a7   Remove -Wdeclaration-after-statement
    adds  2c33f74   extcap: fix heap-use-after free after saving prefs


Summary of changes:
 extcap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)