Wireshark-commits: [Wireshark-commits] master 3120536: Have TPKT support a TCP port range preferenc
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Sep 2016 14:58:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3120536012bc85361e2e5cd204bd4aa91fb67ff6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3120536 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Have TPKT support a TCP port range preference instead of having "subdissectors?" register their own.
    
    There are a number of dissectors who are subdissectors of TPKT (and OSITP) that are
    not called by TCP dissector directly, yet can possibly register a TCP port "on the
    behalf" of TPKT.  Just allow TPKT to support a range of ports to possibly include
    these protocols.
    Remove the preferences from these dissectors, but add backwards compatibility for
    the preferences by hooking into set_prefs and have the preferences just hook into
    Decode As functionality directly.
    
    Change-Id: Ic1b4959d39607f2b6b20fa6508da8d87d04cf098
    Reviewed-on: https://code.wireshark.org/review/17476
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d67c1db   extcap: make extcap use the ws_strtoi/u functions.
    adds  3120536   Have TPKT support a TCP port range preference instead of having "subdissectors?" register their own.


Summary of changes:
 epan/dissectors/asn1/dap/packet-dap-template.c   |   37 ++------------
 epan/dissectors/asn1/disp/packet-disp-template.c |   37 +++-----------
 epan/dissectors/asn1/dop/packet-dop-template.c   |   36 ++------------
 epan/dissectors/asn1/dsp/packet-dsp-template.c   |   36 ++------------
 epan/dissectors/asn1/p1/packet-p1-template.c     |   36 +++-----------
 epan/dissectors/asn1/p7/packet-p7-template.c     |   37 ++------------
 epan/dissectors/packet-dap.c                     |   55 ++++++--------------
 epan/dissectors/packet-disp.c                    |   49 +++++-------------
 epan/dissectors/packet-dop.c                     |   48 ++++--------------
 epan/dissectors/packet-dsp.c                     |   48 ++++--------------
 epan/dissectors/packet-p1.c                      |   56 ++++++---------------
 epan/dissectors/packet-p7.c                      |   57 ++++++---------------
 epan/dissectors/packet-rdp.c                     |   38 ++------------
 epan/dissectors/packet-tpkt.c                    |   35 ++++++++++---
 epan/prefs.c                                     |   58 ++++++++++++++++++++++
 15 files changed, 202 insertions(+), 461 deletions(-)