Wireshark-commits: [Wireshark-commits] master c5a477e: S1AP: add dissection of NB-IoT transparent c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 15 Sep 2016 12:31:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5a477e72aafa76331c3d13d97c39059ffa99605
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c5a477e by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    S1AP: add dissection of NB-IoT transparent containers
    
    To do so, memorize whether a given eNB UE S1AP ID belongs to a NB-IoT
    TAI or not.
    Also add a preference allowing to force dissection as legacy LTE or
    NB-IoT if automatic mode fails.
    While we are at it, let's remove the global variables and introduce
    a S1AP private data info stored in pinfo.
    
    Change-Id: I7e30b3d59d909684e5cfe13510293ed38ad52574
    Reviewed-on: https://code.wireshark.org/review/17709
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  f2e7977   eap: fix EAPOL conversation tracking, fixes TLS decryption
    adds  c5a477e   S1AP: add dissection of NB-IoT transparent containers


Summary of changes:
 epan/dissectors/asn1/lte-rrc/lte-rrc.cnf         |   10 +-
 epan/dissectors/asn1/s1ap/packet-s1ap-template.c |  146 +-
 epan/dissectors/asn1/s1ap/s1ap.cnf               |  175 ++-
 epan/dissectors/packet-lte-rrc.c                 | 1750 +++++++++++++---------
 epan/dissectors/packet-lte-rrc.h                 |    2 +
 epan/dissectors/packet-s1ap.c                    |  660 +++++---
 6 files changed, 1771 insertions(+), 972 deletions(-)