Wireshark-commits: [Wireshark-commits] master-2.2 8960d2e: Remove unnecessary extcap_cleanup() decl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Sep 2016 16:58:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8960d2e8c11cf3f573c5acbacc1b558cd493a808
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8960d2e by Guy Harris (guy@xxxxxxxxxxxx):

    Remove unnecessary extcap_cleanup() declaration.
    
    That wasn't sufficient to avoid #ifdeffing calls to extcap_cleanup(), as
    this header wasn't even being included if HAVE_EXTCAP wasn't defined,
    hence change I18c855e13281013a6277c1f38eeac92e74d52b34 was necessary.
    
    It's probably best that this not be included if HAVE_EXTCAP isn't
    defined, so as to catch *other* references to functions etc. that aren't
    available without extcap.
    
    Change-Id: I5c4ad331b6df93bbbcd28ad3b9815e4cd226039a
    Reviewed-on: https://code.wireshark.org/review/17666
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit f2d6d07498b42637134a08459458cdda679380e0)
    Reviewed-on: https://code.wireshark.org/review/17671
    

Actions performed:

    from  c837ecc   fix some compilation issues without extcap.
    adds  8960d2e   Remove unnecessary extcap_cleanup() declaration.


Summary of changes:
 extcap.h |    4 ----
 1 file changed, 4 deletions(-)