Wireshark-commits: [Wireshark-commits] master 159d431: androiddump: fix memleaks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Sep 2016 12:23:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=159d4317dc5eff3a450bac44610f9023e96b50e5
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

159d431 by Peter Wu (peter@xxxxxxxxxxxxx):

    androiddump: fix memleaks
    
    Most of the actions (e.g.  `androiddump --extcap-interfaces`) return
    immediately without cleaning up. Fix this by adding a common exit path.
    
    Change-Id: If02b18da49d866fb5525306e52fbf4590d98ecd2
    Reviewed-on: https://code.wireshark.org/review/17634
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  26bf66f   extcap: plug more memory leaks
    adds  159d431   androiddump: fix memleaks


Summary of changes:
 extcap/androiddump.c |   58 ++++++++++++++++++++++++++++++--------------------
 1 file changed, 35 insertions(+), 23 deletions(-)