Wireshark-commits: [Wireshark-commits] master c64762d: extcap: Fix misc memory leaks triggered by n
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Sep 2016 12:14:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c64762d33c3a9cbc4af4040284534b440d12b210
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c64762d by Mikael Kanstrup (mikael.kanstrup@xxxxxxxxx):

    extcap: Fix misc memory leaks triggered by network interface changes
    
    Valgrind reports plenty of misc memory leaks in extcap after the network
    interface list has changed or is refreshed. Errors can be seen by
    starting Wireshark with Valgrind's memcheck tool and bringing a network
    interface up and down a few times with:
    
    ifconfig eth0 up
    ifconfig eth0 down
    
    Change-Id: I90f53847071854b7d02facb39b7a380732de79b4
    Reviewed-on: https://code.wireshark.org/review/17606
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e079862   cmake: fix breakage with libnl2
    adds  c64762d   extcap: Fix misc memory leaks triggered by network interface changes


Summary of changes:
 extcap.c                        |   60 ++++++++++++++++++++++++++++-----------
 extcap.h                        |    9 ++++++
 extcap_parser.c                 |   37 +++++++++++++++---------
 extcap_spawn.c                  |    3 ++
 ui/qt/extcap_options_dialog.cpp |   12 +++++---
 5 files changed, 86 insertions(+), 35 deletions(-)