Wireshark-commits: [Wireshark-commits] master 4a6dde1: Have "All Capture Files" match only capture
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a6dde12d6fe6af05b05d4c06b10056f6508711a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
4a6dde1 by Guy Harris (guy@xxxxxxxxxxxx):
Have "All Capture Files" match only capture files.
We support reading some types of files that aren't capture files, in
case we have a dissector for that file format (because, for example,
it's often transported over HTTP). Don't include them in the set of
files "All Capture Files" matches; you can still look for them as they
have individual entries in the drop-down menu of file type patterns.
Ultimately, there should be Fileshark/TFileshark programs to read those
files - and other file types, and even capture files if the goal is to
look at the file structure rather than at the packets - and *that's* the
program that should offer the ability to load JPEGs and so on.
(No, this does not reduce the "All Capture Files" list down to a level
that makes the problem in bug 12837 go away. The right way to fix
*that* is to arrange, somehow, that the "All Capture Files" entry not
actually list all the suffixes it matches.)
Change-Id: I705bff5fcd0694c6c6a11892621a195aa7cd0264
Reviewed-on: https://code.wireshark.org/review/17619
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from d1cacbb PortableApps: Allow multiple instances.
adds 4a6dde1 Have "All Capture Files" match only capture files.
Summary of changes:
ui/qt/capture_file_dialog.cpp | 9 ++--
ui/win32/file_dlg_win32.c | 9 ++--
wiretap/file_access.c | 95 ++++++++++++++++++++++++-----------------
wiretap/wtap.h | 22 ++++++----
4 files changed, 78 insertions(+), 57 deletions(-)
