Wireshark-commits: [Wireshark-commits] master 559bb37: Remove name resolution from the file dialogs
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=559bb375c1542f6556b4afc260345eb6a988025b
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
559bb37 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Remove name resolution from the file dialogs.
A single name resolution checkbox was added to the file dialog way back
in 2000 in g0f7cf64. At that time it was needed because resolution was
synchronous and could drastically affect your load time. Since then
we've added asynchronous name resolution and more recently made it
mandatory (ge005bc8). We've also added more name resolution checkboxes
and other controls.
Remove the name resolution checkboxes. You can just as easily change
resolution options before or after opening a file and they take up
valuable real estate.
Combine the size and packets in the Qt and Win32 dialogs and
pretty-print the size. Combine the start and elapsed times in the Qt,
Win32, and GTK+ dialogs. This lets us shrink the custom areas of the
file dialogs even further. Make the default file type combo item more
descriptive.
Change-Id: Id770adc0f284a4c7f08ee5a7db84f8435f4bf907
Reviewed-on: https://code.wireshark.org/review/17597
Tested-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from ecd82d0 X2AP: shorten field description
adds 559bb37 Remove name resolution from the file dialogs.
Summary of changes:
image/file_dlg_win32.rc | 56 +++++++++---------
ui/gtk/capture_file_dlg.c | 90 +++++++----------------------
ui/qt/capture_file_dialog.cpp | 125 ++++++++++-------------------------------
ui/qt/capture_file_dialog.h | 10 +---
ui/win32/file_dlg_win32.c | 75 +++++++++----------------
ui/win32/file_dlg_win32.h | 22 +++-----
6 files changed, 115 insertions(+), 263 deletions(-)
