Wireshark-commits: [Wireshark-commits] master-2.0 4c570fa: ISAKMP: Fix handling of cert requests wi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 Sep 2016 04:10:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c570fae8899fe7703097cc060965acec4273747
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4c570fa by Mirko Parthey (mirko.parthey@xxxxxx):

    ISAKMP: Fix handling of cert requests without CA
    
    Check IKEv1 Certificate Request Payloads for an empty
    Certificate Authority field, which is allowed by RFC 2408.
    Suppress dissection of this field if it is indeed empty.
    
    Change-Id: Ifb997e460a4c12003215fde86c374cfc769c5d72
    Reviewed-on: https://code.wireshark.org/review/17501
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 70f3737c3e4d9402cb2bb67cdd892e0e7e0ee991)
    Reviewed-on: https://code.wireshark.org/review/17504
    (cherry picked from commit e553366562bd04fd9a2aa7937c49b9291e84a77e)
    Reviewed-on: https://code.wireshark.org/review/17505
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  227382f   S1AP: fix dissection of TransportLayerAddress IE when it contains both IPv4 and IPv6
    adds  4c570fa   ISAKMP: Fix handling of cert requests without CA


Summary of changes:
 epan/dissectors/packet-isakmp.c |    3 +++
 1 file changed, 3 insertions(+)