Wireshark-commits: [Wireshark-commits] master 893e0e9: Qt: Add a timeline indicator to conversation
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=893e0e96084fe0e559310d117fb953ddf08c0d6e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
893e0e9 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Add a timeline indicator to conversations.
Add a timeline indicator to the Start and Duration columns in the
Conversations dialog. Add tooltips to the columns that explain what's
going on.
Round the timeline rect corners and do the same for Prototocol Hierarchy
Statistics. This should hopefully differentiate the graph bars from a
text selection and IMHO it looks better.
Update the PHS and Conversations images in the User's Guide.
Change-Id: I61d6c25843be522cc444e01ba77cb5b1e991fa36
Reviewed-on: https://code.wireshark.org/review/17396
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 2ddb46d btavctp: rework the reassemble routine (CID 1355682).
adds 893e0e9 Qt: Add a timeline indicator to conversations.
Summary of changes:
docbook/wsug_graphics/ws-stats-conversations.png | Bin 104894 -> 250943 bytes
docbook/wsug_graphics/ws-stats-hierarchy.png | Bin 21480 -> 181226 bytes
docbook/wsug_src/WSUG_chapter_statistics.asciidoc | 24 +++----
ui/qt/CMakeLists.txt | 2 +
ui/qt/Makefile.am | 2 +
ui/qt/conversation_dialog.cpp | 70 +++++++++++++++++++-
ui/qt/conversation_dialog.h | 4 ++
ui/qt/percent_bar_delegate.cpp | 26 +++++---
...cent_bar_delegate.cpp => timeline_delegate.cpp} | 68 ++++++++++---------
...lated_packet_delegate.h => timeline_delegate.h} | 64 +++++++++---------
10 files changed, 171 insertions(+), 89 deletions(-)
copy ui/qt/{percent_bar_delegate.cpp => timeline_delegate.cpp} (62%)
copy ui/qt/{related_packet_delegate.h => timeline_delegate.h} (55%)
