Wireshark-commits: [Wireshark-commits] master-2.2 0b45da6: diameter: fix 400kb leaked memory on exi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 2 Sep 2016 19:22:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b45da651d07b89df529366e4ac5cb29adf2c232
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

0b45da6 by Peter Wu (peter@xxxxxxxxxxxxx):

    diameter: fix 400kb leaked memory on exit
    
    Before:
    
        SUMMARY: AddressSanitizer: 399684 byte(s) leaked in 17208 allocation(s).
    
    After addressing to-do by calling ddict_free:
    
        SUMMARY: AddressSanitizer: 3024 byte(s) leaked in 256 allocation(s).
    
    After fixing all remaining leaks cases in the flex file for diameter:
    
        SUMMARY: AddressSanitizer: 735 byte(s) leaked in 58 allocation(s).
    
    Not bad huh :-)
    
    Ping-Bug: 12790
    Change-Id: I0c730ad77ae15c69390bc6cf0a3a985395a64771
    Reviewed-on: https://code.wireshark.org/review/17364
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit a04b6fcb3db901734ed948134c973996786be8b7)
    Reviewed-on: https://code.wireshark.org/review/17464
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  357e063   tvbparse: fix memleak
    adds  0b45da6   diameter: fix 400kb leaked memory on exit


Summary of changes:
 epan/diam_dict.l                  |   35 ++++++++++++++++++++++++++++-------
 epan/dissectors/packet-diameter.c |   12 ++++++++++--
 2 files changed, 38 insertions(+), 9 deletions(-)