Wireshark-commits: [Wireshark-commits] master 16b7128: UAT gtk-ui, Qt-ui: Fixed copying records whe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 28 Aug 2016 16:08:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16b7128d1a4b4c80d24d5a10e32a5787727858a9
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

16b7128 by Michał Skalski (mskalski13@xxxxxxxxx):

    UAT gtk-ui, Qt-ui: Fixed copying records when no cp callback is defined
    
    According to documentation of uat_copy_cb_t, if uat->copy_cb is NULL,
    memcpy() should be used.
    
    This affected IKEv1 and IKEv2 UAT tables (possibly others).
    
    
    Change-Id: I27ebdc08385d260945699f101e714d3abb288b22
    Reviewed-on: https://code.wireshark.org/review/17245
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  7da7691   [Automatic update for 2016-08-28]
    adds  16b7128   UAT gtk-ui, Qt-ui: Fixed copying records when no cp callback is defined


Summary of changes:
 ui/gtk/uat_gui.c     |    4 ++++
 ui/qt/uat_dialog.cpp |    9 +++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)