Wireshark-commits: [Wireshark-commits] master d0565ad: Properly end address type search by name (CI
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Aug 2016 16:50:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d0565ad22b14eae64776fb7cf04377e902380ef9
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d0565ad by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Properly end address type search by name (CID-1362742)
    
    Search address type by name iterates over an array, but fails to find its end.
    Therefore it may dereference invalid pointers, or NULL.
    
    Add the proper check in the for loop and make sure an end condition is always
    there in the array searched.
    
    Change-Id: I60ade9d438dc394340b6483b4fcb23e5ce432000
    Reviewed-on: https://code.wireshark.org/review/17337
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  18e1ee7   SDP: Restore usability of conversation debug feature.
    adds  d0565ad   Properly end address type search by name (CID-1362742)


Summary of changes:
 epan/address_types.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)