Wireshark-commits: [Wireshark-commits] master-2.0 72159d2: qt: fix crash on Search Packet while red
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Aug 2016 09:05:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=72159d20cac90865290f74e1779c0643db710f01
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

72159d2 by Peter Wu (peter@xxxxxxxxxxxxx):

    qt: fix crash on Search Packet while redissecting
    
    Before redissection, PacketList::freeze() is called which clears the
    model. This results in a NULL-deref when pressing Ctrl-F (Packet
    Search) or Ctrl-G (Go To Packet). Reproducer: in a large capture file,
    enter some display filter (e.g. "udp") and immediately press Ctrl-F.
    
    Thanks to Github user SNAPESNATCH for the initial report via IRC that
    included a helpful stack trace on Windows.
    
    Change-Id: If7334d6df4e9591fb1f2a52e3e2f837285b2959f
    Reviewed-on: https://code.wireshark.org/review/17326
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 09be46361bab677842cc598405cbc7a44b974f1f)
    Reviewed-on: https://code.wireshark.org/review/17343
    

Actions performed:

    from  0fdce24   cmake: fix build with cmake 2.8.7
    adds  72159d2   qt: fix crash on Search Packet while redissecting


Summary of changes:
 ui/qt/main_window_slots.cpp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)