Wireshark · Wireshark-commits: [Wireshark-commits] master 09be463: qt: fix crash on Search Packet while redissecting

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=09be46361bab677842cc598405cbc7a44b974f1f
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

09be463 by Peter Wu (peter@xxxxxxxxxxxxx):

    qt: fix crash on Search Packet while redissecting
    
    Before redissection, PacketList::freeze() is called which clears the
    model. This results in a NULL-deref when pressing Ctrl-F (Packet
    Search) or Ctrl-G (Go To Packet). Reproducer: in a large capture file,
    enter some display filter (e.g. "udp") and immediately press Ctrl-F.
    
    Thanks to Github user SNAPESNATCH for the initial report via IRC that
    included a helpful stack trace on Windows.
    
    Change-Id: If7334d6df4e9591fb1f2a52e3e2f837285b2959f
    Reviewed-on: https://code.wireshark.org/review/17326
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  17f977e   Handle ETH_P_CANFD as well as ETH_P_CAN.
    adds  09be463   qt: fix crash on Search Packet while redissecting


Summary of changes:
 ui/qt/main_window_slots.cpp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)