Wireshark-commits: [Wireshark-commits] master ce9a4b2: xmpp/xml: Store item length in xml_frame.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Aug 2016 15:13:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce9a4b212ec7b75985cef3b9ab362808e6fd25c5
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ce9a4b2 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    xmpp/xml: Store item length in xml_frame.
    
    The created XML proto_item can be faked (if not visible and not referenced),
    so ensure we store the correct item length to be used in XMPP.
    
    This will avoid an invalid "Malformed Packet" for some XMPP packets.
    
    Change-Id: I79d805b725dbeb93f26a38b72bdcc84187aee16f
    Reviewed-on: https://code.wireshark.org/review/17324
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  f597234   extcap: add binary name and version to help message.
    adds  ce9a4b2   xmpp/xml: Store item length in xml_frame.


Summary of changes:
 epan/dissectors/packet-xml.c        |    7 +++++++
 epan/dissectors/packet-xml.h        |    1 +
 epan/dissectors/packet-xmpp-utils.c |   17 +++--------------
 3 files changed, 11 insertions(+), 14 deletions(-)